From 0ddb3a48383fed8024823a37e4947c402b4a9400 Mon Sep 17 00:00:00 2001 From: grondag Date: Thu, 6 Jun 2019 10:44:54 -0700 Subject: [PATCH] Fix bad flat lighting on inset quads (#253) (#254) --- .../fabricmc/indigo/renderer/render/AbstractQuadRenderer.java | 3 ++- .../indigo/renderer/render/TerrainFallbackConsumer.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/AbstractQuadRenderer.java b/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/AbstractQuadRenderer.java index d79e1bfdf..8c3ef17fa 100644 --- a/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/AbstractQuadRenderer.java +++ b/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/AbstractQuadRenderer.java @@ -27,6 +27,7 @@ import net.fabricmc.indigo.renderer.aocalc.AoCalculator; import net.fabricmc.indigo.renderer.helper.ColorHelper; import net.fabricmc.indigo.renderer.mesh.EncodingFormat; import net.fabricmc.indigo.renderer.mesh.MutableQuadViewImpl; +import net.minecraft.block.Block; import net.minecraft.block.BlockState; import net.minecraft.util.math.BlockPos; @@ -140,7 +141,7 @@ public abstract class AbstractQuadRenderer { */ int flatBrightness(MutableQuadViewImpl quad, BlockState blockState, BlockPos pos) { mpos.set(pos); - if((quad.geometryFlags() & LIGHT_FACE_FLAG) != 0) { + if((quad.geometryFlags() & LIGHT_FACE_FLAG) != 0 || Block.isShapeFullCube(blockState.getCollisionShape(blockInfo.blockView, pos))) { mpos.setOffset(quad.lightFace()); } return brightnessFunc.applyAsInt(blockState, mpos); diff --git a/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/TerrainFallbackConsumer.java b/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/TerrainFallbackConsumer.java index 01b1e131d..8f7bc1888 100644 --- a/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/TerrainFallbackConsumer.java +++ b/fabric-renderer-indigo/src/main/java/net/fabricmc/indigo/renderer/render/TerrainFallbackConsumer.java @@ -132,7 +132,7 @@ public class TerrainFallbackConsumer extends AbstractQuadRenderer implements Con // vanilla compatibility hack // For flat lighting, cull face drives everything and light face is ignored. if(cullFace == null) { - editorQuad.geometryFlags(0); + editorQuad.invalidateShape(); } else { editorQuad.geometryFlags(GeometryHelper.LIGHT_FACE_FLAG); editorQuad.lightFace(cullFace);