ChomeNS/chipmunkmod
2
1
Fork 6
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat: config migrations #7

Merged
ChomeNS merged 1 commit from amy/chomens-chipmunkmod:1.20.1 into 1.20.1 2025-01-03 00:44:09 -05:00
Conversation 0 Commits 1 Files changed 7 +221 -97
amy commented 2025-01-01 23:30:04 -05:00
Contributor
Copy link

Should allow for easy changing of the Configuration class without breaking already existing user configuration.

Please tell me if I've gone too overboard with the abstraction.
I mainly did it so forks could adopt the migration system easily, by just creating their own class and extending from AbstractMigrationManager

I apologize for all the fake changes in Configuration, it looks like git didn't like the fact that it was using CRLF for linebreaks.
Enabling "Ignore whitespace when comparing lines" should hopefully make it better.

Changes:

  • New versioning/migration framework for the Configuration class
  • Unversioned -> v0 migration that just removes the "fullbright" key (as an example of how to work with migrations)
Should allow for easy changing of the Configuration class without breaking already existing user configuration. Please tell me if I've gone too overboard with the abstraction. I mainly did it so forks could adopt the migration system easily, by just creating their own class and extending from AbstractMigrationManager I apologize for all the fake changes in Configuration, it looks like git didn't like the fact that it was using CRLF for linebreaks. Enabling "Ignore whitespace when comparing lines" should hopefully make it better. Changes: - New versioning/migration framework for the Configuration class - Unversioned -> v0 migration that just removes the "fullbright" key (as an example of how to work with migrations)
amy added 1 commit 2025-01-01 23:30:04 -05:00
ChomeNS merged commit e570702901 into 1.20.1 2025-01-03 00:44:09 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ChomeNS/chipmunkmod#7
No description provided.
Delete branch "amy/chomens-chipmunkmod:1.20.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?