From d851d9fc1797ce07bcca34a8821fab3a77776ee7 Mon Sep 17 00:00:00 2001 From: Cheng Liu Date: Wed, 7 Aug 2024 20:17:13 -0700 Subject: [PATCH] feat: remove useless help text service --- .../sparo-lib/src/cli/commands/auto-config.ts | 3 -- apps/sparo-lib/src/cli/commands/base.ts | 1 - apps/sparo-lib/src/cli/commands/checkout.ts | 4 --- .../sparo-lib/src/cli/commands/ci-checkout.ts | 3 -- apps/sparo-lib/src/cli/commands/ci-clone.ts | 4 --- apps/sparo-lib/src/cli/commands/clone.ts | 4 --- apps/sparo-lib/src/cli/commands/fetch.ts | 4 --- .../src/cli/commands/git-checkout.ts | 4 --- apps/sparo-lib/src/cli/commands/git-clone.ts | 4 --- apps/sparo-lib/src/cli/commands/git-fetch.ts | 4 --- apps/sparo-lib/src/cli/commands/git-pull.ts | 3 -- .../src/cli/commands/init-profile.ts | 4 --- .../src/cli/commands/list-profiles.ts | 3 -- apps/sparo-lib/src/cli/commands/pull.ts | 4 --- apps/sparo-lib/src/services/CommandService.ts | 2 -- .../sparo-lib/src/services/HelpTextService.ts | 18 ----------- rush.json | 31 ------------------- 17 files changed, 100 deletions(-) delete mode 100644 apps/sparo-lib/src/services/HelpTextService.ts diff --git a/apps/sparo-lib/src/cli/commands/auto-config.ts b/apps/sparo-lib/src/cli/commands/auto-config.ts index 73198ce..79b03a6 100644 --- a/apps/sparo-lib/src/cli/commands/auto-config.ts +++ b/apps/sparo-lib/src/cli/commands/auto-config.ts @@ -52,7 +52,4 @@ export class AutoConfigCommand implements ICommand { throw e; } }; - public getHelp(): string { - return ''; - } } diff --git a/apps/sparo-lib/src/cli/commands/base.ts b/apps/sparo-lib/src/cli/commands/base.ts index 5b7b7c4..b9760bc 100644 --- a/apps/sparo-lib/src/cli/commands/base.ts +++ b/apps/sparo-lib/src/cli/commands/base.ts @@ -17,5 +17,4 @@ export interface ICommand { builder: (yargs: Argv) => void; handler: (args: ArgumentsCamelCase, terminalService: TerminalService) => Promise; - getHelp: () => string; } diff --git a/apps/sparo-lib/src/cli/commands/checkout.ts b/apps/sparo-lib/src/cli/commands/checkout.ts index 6a87d75..1d9f08c 100644 --- a/apps/sparo-lib/src/cli/commands/checkout.ts +++ b/apps/sparo-lib/src/cli/commands/checkout.ts @@ -258,10 +258,6 @@ export class CheckoutCommand implements ICommand { } }; - public getHelp(): string { - return ''; - } - private _ensureBranchInLocal(branch: string): boolean { // fetch from remote const remote: string = this._gitService.getBranchRemote(branch); diff --git a/apps/sparo-lib/src/cli/commands/ci-checkout.ts b/apps/sparo-lib/src/cli/commands/ci-checkout.ts index fc7452f..047fce3 100644 --- a/apps/sparo-lib/src/cli/commands/ci-checkout.ts +++ b/apps/sparo-lib/src/cli/commands/ci-checkout.ts @@ -44,7 +44,4 @@ export class CICheckoutCommand implements ICommand { from }); }; - public getHelp(): string { - return 'sparse help'; - } } diff --git a/apps/sparo-lib/src/cli/commands/ci-clone.ts b/apps/sparo-lib/src/cli/commands/ci-clone.ts index 131b455..c03594b 100644 --- a/apps/sparo-lib/src/cli/commands/ci-clone.ts +++ b/apps/sparo-lib/src/cli/commands/ci-clone.ts @@ -71,8 +71,4 @@ export class CICloneCommand implements ICommand { terminal.writeLine(`Remember to run "cd ${directory}"`); }; - - public getHelp(): string { - return `clone help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/clone.ts b/apps/sparo-lib/src/cli/commands/clone.ts index d63fa3b..8a5b3f6 100644 --- a/apps/sparo-lib/src/cli/commands/clone.ts +++ b/apps/sparo-lib/src/cli/commands/clone.ts @@ -154,8 +154,4 @@ export class CloneCommand implements ICommand { terminal.writeLine(' ' + Colorize.cyan('sparo init-profile --profile ')); } }; - - public getHelp(): string { - return `clone help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/fetch.ts b/apps/sparo-lib/src/cli/commands/fetch.ts index 974ecdb..cce677d 100644 --- a/apps/sparo-lib/src/cli/commands/fetch.ts +++ b/apps/sparo-lib/src/cli/commands/fetch.ts @@ -75,8 +75,4 @@ export class FetchCommand implements ICommand { restoreSingleBranchCallback?.(); }; - - public getHelp(): string { - return `fetch help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/git-checkout.ts b/apps/sparo-lib/src/cli/commands/git-checkout.ts index ef35cef..8d8b414 100644 --- a/apps/sparo-lib/src/cli/commands/git-checkout.ts +++ b/apps/sparo-lib/src/cli/commands/git-checkout.ts @@ -27,8 +27,4 @@ export class GitCheckoutCommand implements ICommand<{}> { terminal.writeDebugLine(`proxy args in git-checkout command: ${JSON.stringify(rawArgs)}`); gitService.executeGitCommand({ args: rawArgs }); }; - - public getHelp(): string { - return `git-checkout help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/git-clone.ts b/apps/sparo-lib/src/cli/commands/git-clone.ts index 1eb7cc7..540b237 100644 --- a/apps/sparo-lib/src/cli/commands/git-clone.ts +++ b/apps/sparo-lib/src/cli/commands/git-clone.ts @@ -27,8 +27,4 @@ export class GitCloneCommand implements ICommand<{}> { terminal.writeDebugLine(`proxy args in git-clone command: ${JSON.stringify(rawArgs)}`); gitService.executeGitCommand({ args: rawArgs }); }; - - public getHelp(): string { - return `git-clone help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/git-fetch.ts b/apps/sparo-lib/src/cli/commands/git-fetch.ts index 4cb78cb..51d80c8 100644 --- a/apps/sparo-lib/src/cli/commands/git-fetch.ts +++ b/apps/sparo-lib/src/cli/commands/git-fetch.ts @@ -28,8 +28,4 @@ export class GitFetchCommand implements ICommand<{}> { terminal.writeDebugLine(`proxy args in git-fetch command: ${JSON.stringify(rawArgs)}`); gitService.executeGitCommand({ args: rawArgs }); }; - - public getHelp(): string { - return `git-fetch help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/git-pull.ts b/apps/sparo-lib/src/cli/commands/git-pull.ts index 903e1ec..68ddc25 100644 --- a/apps/sparo-lib/src/cli/commands/git-pull.ts +++ b/apps/sparo-lib/src/cli/commands/git-pull.ts @@ -27,7 +27,4 @@ export class GitPullCommand implements ICommand<{}> { terminal.writeDebugLine(`proxy args in git-pull command: ${JSON.stringify(rawArgs)}`); gitService.executeGitCommand({ args: rawArgs }); }; - public getHelp(): string { - return `git-pull help`; - } } diff --git a/apps/sparo-lib/src/cli/commands/init-profile.ts b/apps/sparo-lib/src/cli/commands/init-profile.ts index 3cadb2c..d672426 100644 --- a/apps/sparo-lib/src/cli/commands/init-profile.ts +++ b/apps/sparo-lib/src/cli/commands/init-profile.ts @@ -66,8 +66,4 @@ export class InitProfileCommand implements ICommand this._terminalService.terminal.writeLine(); this._terminalService.terminal.writeLine(' ' + Colorize.cyan(destinationPath)); }; - - public getHelp(): string { - return 'init-profile help'; - } } diff --git a/apps/sparo-lib/src/cli/commands/list-profiles.ts b/apps/sparo-lib/src/cli/commands/list-profiles.ts index e7636be..fa9ec82 100644 --- a/apps/sparo-lib/src/cli/commands/list-profiles.ts +++ b/apps/sparo-lib/src/cli/commands/list-profiles.ts @@ -85,7 +85,4 @@ export class ListProfilesCommand implements ICommand { isProfileRestoreFromLocal }); }; - - public getHelp(): string { - return `pull help`; - } } diff --git a/apps/sparo-lib/src/services/CommandService.ts b/apps/sparo-lib/src/services/CommandService.ts index 56fe551..df589fb 100644 --- a/apps/sparo-lib/src/services/CommandService.ts +++ b/apps/sparo-lib/src/services/CommandService.ts @@ -1,7 +1,6 @@ import { inject } from 'inversify'; import type { Argv } from 'yargs'; import type { ICommand } from '../cli/commands/base'; -import { HelpTextService } from './HelpTextService'; import { TerminalService } from './TerminalService'; import { Service } from '../decorator'; import { ArgvService } from './ArgvService'; @@ -63,7 +62,6 @@ export class CommandService { } } ); - this._helpTextService.set(commandName, getHelp()); } public setHasInternalError(): void { diff --git a/apps/sparo-lib/src/services/HelpTextService.ts b/apps/sparo-lib/src/services/HelpTextService.ts deleted file mode 100644 index 8622e49..0000000 --- a/apps/sparo-lib/src/services/HelpTextService.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { inject } from 'inversify'; -import { Service } from '../decorator'; -import { TerminalService } from './TerminalService'; - -export interface IHelpTextParams { - terminalService: TerminalService; -} -@Service() -export class HelpTextService { - @inject(TerminalService) private _terminalService!: TerminalService; - - public helpTextMap: Map = new Map(); - - public set(name: string, text: string): void { - this._terminalService.terminal.writeVerboseLine(`set help text "${name}" to "${text}"`); - this.helpTextMap.set(name, text); - } -} diff --git a/rush.json b/rush.json index bc4eb88..5ecca4d 100644 --- a/rush.json +++ b/rush.json @@ -270,37 +270,6 @@ "postRushx": [] }, - /** - * Installation variants allow you to maintain a parallel set of configuration files that can be - * used to build the entire monorepo with an alternate set of dependencies. For example, suppose - * you upgrade all your projects to use a new release of an important framework, but during a transition period - * you intend to maintain compatibility with the old release. In this situation, you probably want your - * CI validation to build the entire repo twice: once with the old release, and once with the new release. - * - * Rush "installation variants" correspond to sets of config files located under this folder: - * - * common/config/rush/variants/ - * - * The variant folder can contain an alternate common-versions.json file. Its "preferredVersions" field can be used - * to select older versions of dependencies (within a loose SemVer range specified in your package.json files). - * To install a variant, run "rush install --variant ". - * - * For more details and instructions, see this article: https://rushjs.io/pages/advanced/installation_variants/ - */ - "variants": [ - // { - // /** - // * The folder name for this variant. - // */ - // "variantName": "old-sdk", - // - // /** - // * An informative description - // */ - // "description": "Build this repo using the previous release of the SDK" - // } - ], - /** * Rush can collect anonymous telemetry about everyday developer activity such as * success/failure of installs, builds, and other operations. You can use this to identify