From bd6bfb661f1c92dd6cfa0e269eecbf0c93aad4aa Mon Sep 17 00:00:00 2001
From: Explodingbill <talgood09@gmail.com>
Date: Sat, 16 Nov 2024 15:03:10 +1100
Subject: [PATCH] asdf

---
 loader/include/Geode/ui/OverlayManager.hpp |  5 +----
 loader/src/ui/nodes/OverlayManager.cpp     | 21 ++++-----------------
 2 files changed, 5 insertions(+), 21 deletions(-)

diff --git a/loader/include/Geode/ui/OverlayManager.hpp b/loader/include/Geode/ui/OverlayManager.hpp
index a569d345..cb853163 100644
--- a/loader/include/Geode/ui/OverlayManager.hpp
+++ b/loader/include/Geode/ui/OverlayManager.hpp
@@ -14,7 +14,7 @@ namespace geode
     I added this, a simple class to add nodes to a general notification node so that mods dont interfere with each other.
     */
 
-    class GEODE_DLL OverlayManager : public cocos2d::CCNode
+    class GEODE_DLL OverlayManager : private cocos2d::CCNode
     {
         private:
             std::vector<cocos2d::CCNode*> nodes;
@@ -29,9 +29,6 @@ namespace geode
             /// @brief Removes a node from the overlay manager, stopping it from being drawn. This will release the node
             void removeNode(cocos2d::CCNode* node);
 
-            /// @brief Sorts all overlays by their ZOrder and draws them
-            virtual void visit();
-
             /// @brief Util to get the highest ZOrder of all nodes
             int getHighestOverlayZOrder();
 
diff --git a/loader/src/ui/nodes/OverlayManager.cpp b/loader/src/ui/nodes/OverlayManager.cpp
index 012a62a7..c76131bb 100644
--- a/loader/src/ui/nodes/OverlayManager.cpp
+++ b/loader/src/ui/nodes/OverlayManager.cpp
@@ -18,34 +18,21 @@ OverlayManager* OverlayManager::get()
 
 void OverlayManager::addNode(CCNode* node)
 {
-    node->retain();
+    this->addChild(node);
 
     nodes.push_back(node);
 }
 
 void OverlayManager::removeNode(CCNode* node)
 {
-    node->release();
+    this->removeChild(node);
 
     std::erase(nodes, node);
 }
 
-void OverlayManager::visit()
-{
-    std::sort(nodes.begin(), nodes.end(), [](CCNode* a, CCNode* b)
-    {
-        return a->getZOrder() < b->getZOrder();
-    });
-
-    for (auto node : nodes)
-    {
-        node->visit();
-    }
-}
-
 int OverlayManager::getHighestOverlayZOrder()
 {
-    int z = 0;
+    int z = INT_MIN;
 
     for (auto node : nodes)
     {
@@ -58,7 +45,7 @@ int OverlayManager::getHighestOverlayZOrder()
 
 int OverlayManager::getLowestOverlayZOrder()
 {
-    int z = 0;
+    int z = INT_MAX;
 
     for (auto node : nodes)
     {