From 5b10a91d8c9a39eac07b12af8c646be56ac86284 Mon Sep 17 00:00:00 2001 From: matcool <26722564+matcool@users.noreply.github.com> Date: Sun, 10 Nov 2024 00:43:06 -0300 Subject: [PATCH] do a few v4 todos --- loader/include/Geode/loader/Mod.hpp | 1 - loader/include/Geode/loader/ModEvent.hpp | 3 --- loader/src/loader/ModImpl.cpp | 1 - 3 files changed, 5 deletions(-) diff --git a/loader/include/Geode/loader/Mod.hpp b/loader/include/Geode/loader/Mod.hpp index aff3aa8a..6a7ddbd0 100644 --- a/loader/include/Geode/loader/Mod.hpp +++ b/loader/include/Geode/loader/Mod.hpp @@ -157,7 +157,6 @@ namespace geode { std::vector getSettingKeys() const; bool hasSetting(std::string_view const key) const; - // todo in v4: possibly rename this to getSetting? /** * Get the definition of a setting, or null if the setting was not found, * or if it's a custom setting that has not yet been registered using diff --git a/loader/include/Geode/loader/ModEvent.hpp b/loader/include/Geode/loader/ModEvent.hpp index b9801c2c..5b88f0f7 100644 --- a/loader/include/Geode/loader/ModEvent.hpp +++ b/loader/include/Geode/loader/ModEvent.hpp @@ -10,9 +10,6 @@ namespace geode { enum class ModEventType { Loaded, - Unloaded, - Enabled, - Disabled, DataLoaded, DataSaved, }; diff --git a/loader/src/loader/ModImpl.cpp b/loader/src/loader/ModImpl.cpp index cc345252..10903eb2 100644 --- a/loader/src/loader/ModImpl.cpp +++ b/loader/src/loader/ModImpl.cpp @@ -321,7 +321,6 @@ Result<> Mod::Impl::loadBinary() { ModStateEvent(m_self, ModEventType::Loaded).post(); - ModStateEvent(m_self, ModEventType::Enabled).post(); ModStateEvent(m_self, ModEventType::DataLoaded).post(); m_isCurrentlyLoading = false;